-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send original error in ProxyGetRequest #1516
Conversation
I tried using an enum instead of deserializing in two places, but it did not work, serde kept failing with "data did not match any variant of untagged enum". I think it has something to do with untagged enums expecting all parameters of the json object to be in the variant's struct, while structs will deserialize even if the json contains extra fields. |
Yes, we are using serde_json::value::RawValue which doesn't work with untagged enums serde-rs/json#779 |
If you merge master then the UI tests should pass I fixed it right now, new stable rust version broke it |
Co-authored-by: Niklas Adolfsson <[email protected]>
Looks good, nice work |
closes #1515